Add Vite driver #3952
Merged
Add Vite driver #3952
+486
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Everything looks great to me. Spot on! |
thetutlage
added
the
Type: Feature Request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs to be tested
Several things are worth noting:
Vite does not generate manifests during development. So concretely, it's not really a problem, you can still load the assets. The only drawback is that in dev, if you try to load an asset that doesn't exist, you won't get an error in the terminal console. However, you will obviously get an error in the browser.
Vite does not generate a "entrypoints.json" file like Encore. So I added this feature in the Vite plugin which I will publish soon.
The vite plugin I made will generate an entrpoints.json file exactly the same way as Encore, in dev and at build time. This will allow us to keep exactly the same API as Encore and especially not create any breaking changes. The helpers
entryPointsStyleandentryPointsScriptswill be usable in the same way.