Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'guard' is never reassigned. Use 'const' instead. #225

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leofmarciano
Copy link

@leofmarciano leofmarciano commented Oct 25, 2023

Proposed changes

This pull request addresses the prefer-const issue identified in our codebase. The change involves modifying the guard variable declaration from let to const in the authentication loop, as this variable is never reassigned. This change aligns with the global standard "prefer-const" of using const for variables that will not be mutated later.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

The prefer-const rule is a widely accepted best practice in JavaScript and TypeScript development. It helps to prevent unintentional mutation of variables and makes the code easier to reason about. By making this change, we ensure that our code adheres to this best practice, making it more robust and maintainable.

'guard' is never reassigned. Use 'const' instead.
@leofmarciano leofmarciano changed the title ISSUE: prefer-const 'guard' is never reassigned. Use 'const' instead. Oct 25, 2023
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned Dropped and not into consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant