Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency patch: cc 1.0.86 (just released) breaks xmp_toolkit_rs when used in downstream cargo install #194

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

scouten-adobe
Copy link
Member

No description provided.

@scouten-adobe scouten-adobe self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63346d1) 98.12% compared to head (47b5c87) 98.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files           9        9           
  Lines        1763     1763           
=======================================
  Hits         1730     1730           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe changed the title Emergency patch: cc 1.0.86 (just released) breaks xmp_toolkit_rs when used in upstream cargo install Emergency patch: cc 1.0.86 (just released) breaks xmp_toolkit_rs when used in downstream cargo install Feb 21, 2024
@scouten-adobe
Copy link
Member Author

Working on a personal (private / closed source, sorry) project that uses this xmp_toolkit just now, I was abruptly unable to build xmp-toolkit, but only when using the downstream project's cargo install process.

I was able to trace it down to the cc crate which was released a few hours ago. Not sure what changed, but pinning it back to the previous release "fixes" the problem.

It's late for me here; can work on investigating further if cc team needs it.

@scouten-adobe scouten-adobe merged commit a6d0c2c into main Feb 21, 2024
25 of 29 checks passed
@scouten-adobe scouten-adobe deleted the quick-fix-avoid-cc-1.0.86 branch February 21, 2024 05:01
@scouten-adobe
Copy link
Member Author

Intentionally ignoring non-critical build errors.

@scouten-adobe
Copy link
Member Author

Xref: rust-lang/cc-rs#959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant