-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(picker): added a new interaction strategy #4396
Open
TarunAdobe
wants to merge
4
commits into
main
Choose a base branch
from
bug/picker-auto-slection
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChromeaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
picker permalinkbasic-test
split-button permalinkbasic-test
Firefoxaction-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
picker permalinkbasic-test
split-button permalinkbasic-test
|
TarunAdobe
force-pushed
the
bug/picker-auto-slection
branch
from
May 23, 2024 06:53
a5d671b
to
106aa6c
Compare
TarunAdobe
changed the title
[DRAFT]: Testing an Interaction Controller Strategy for Picker Component
chore: Adding a Interaction Controller Strategy for Picker Component
May 23, 2024
TarunAdobe
changed the title
chore: Adding a Interaction Controller Strategy for Picker Component
chore: Adding an Interaction Controller Strategy for Picker Component
May 23, 2024
TarunAdobe
force-pushed
the
bug/picker-auto-slection
branch
from
May 23, 2024 07:10
106aa6c
to
757b90e
Compare
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
TarunAdobe
changed the title
chore: Adding an Interaction Controller Strategy for Picker Component
chore(picker): added a new interaction strategy
May 28, 2024
TarunAdobe
force-pushed
the
bug/picker-auto-slection
branch
from
May 30, 2024 12:50
814916d
to
28a86be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expected behavior
pointerup
in mobile should not automatically make a selection.Actual behavior
pointerup
in mobile works like in desktop and automatically makes a selection.Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.