Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use lerna 8 and still publish react wrappers #4385

Merged
merged 1 commit into from
May 24, 2024

Conversation

Westbrook
Copy link
Contributor

Description

  • update to latest lerna
  • rework the publish script to prevent the fact that /react is .gitignored by default from preventing lerna from publishing it

How has this been tested?

  • Test case 1
    1. Do a publish
    2. Make sure it works
    3. Make sure that /react isn't actually added to the project

Types of changes

  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

github-actions bot commented May 2, 2024

Branch preview

Copy link

github-actions bot commented May 2, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.95 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 221.186 kB 210.436 kB 210.021 kB 🏆
Scripts 53.623 kB 48.182 kB 47.974 kB 🏆
Stylesheet 34.814 kB 30.334 kB 30.269 kB 🏆
Document 5.885 kB 5.268 kB 5.181 kB 🏆
Font 126.864 kB 126.652 kB 126.597 kB 🏆

Request Count

Category Latest Main Branch
Total 45 45 45
Scripts 37 37 37
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

Copy link

github-actions bot commented May 2, 2024

Tachometer results

Currently, no packages are changed by this PR...

package.json Outdated Show resolved Hide resolved
@Westbrook Westbrook force-pushed the update-lerna branch 3 times, most recently from 44418ba to aa7fb3d Compare May 9, 2024 12:07
@Westbrook Westbrook force-pushed the update-lerna branch 2 times, most recently from a289cf9 to f2bb13e Compare May 10, 2024 12:41
@Westbrook Westbrook force-pushed the update-lerna branch 2 times, most recently from 77d94f2 to da7e64c Compare May 10, 2024 13:59
@Westbrook Westbrook mentioned this pull request May 20, 2024
12 tasks
@Westbrook Westbrook force-pushed the update-lerna branch 5 times, most recently from 2f60b02 to faf6932 Compare May 24, 2024 15:55
@Westbrook Westbrook changed the base branch from main to upgrade/husky May 24, 2024 15:56
@Westbrook Westbrook merged commit cac19b7 into upgrade/husky May 24, 2024
56 of 57 checks passed
@Westbrook Westbrook deleted the update-lerna branch May 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants