feat(alert-banner): add alert banner component #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 12, 2024 13:10
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
|
Rajdeepc
reviewed
Apr 19, 2024
Rajdeepc
reviewed
Apr 19, 2024
Westbrook
reviewed
Apr 22, 2024
Rajdeepc
reviewed
Apr 29, 2024
|
Please check the below issues by changing different device types. 
|
loredanaspataru
force-pushed
the
lspataru/alert-banner
branch
from
1da7740
to
8b83f2a
Compare
Rajdeepc
reviewed
May 27, 2024
There was a problem hiding this comment.
Can you make sure that you also include memory tests like this
https://github.com/adobe/spectrum-web-components/blob/main/packages/alert-dialog/test/alert-dialog-memory.test.ts
| @@ -0,0 +1,97 @@ | |||
| ## Description | |||
|
|
|||
| The `sp-alert-banner` shows pressing and high-signal messages, such as system alerts. It is meant to be noticed and prompt users to take action. | |||
There was a problem hiding this comment.
Suggested change
| The `sp-alert-banner` shows pressing and high-signal messages, such as system alerts. It is meant to be noticed and prompt users to take action. | |
| The `<sp-alert-banner>` shows pressing and high-signal messages, such as system alerts. It is meant to be noticed and prompt users to take action. |
|
|
||
| The component dispatches a `close` event to announce that the alert banner has been closed. This can be prevented by using the `event.preventDefault()` API. | ||
|
|
||
| ## Accesibility |
There was a problem hiding this comment.
Suggested change
| ## Accesibility | |
| ## Accessibility |
| switch (variant) { | ||
| case 'info': | ||
| return html` | ||
| <sp-icon-info |
There was a problem hiding this comment.
Is this not customisable?
|
|
||
| expect(el.open).to.be.false; | ||
| }); | ||
| it('can be dismissed using public close method', async () => { |
There was a problem hiding this comment.
Suggested change
| it('can be dismissed using public close method', async () => { | |
| it('can be dismissed using close button', async () => { |
|
|
||
| expect(el.open).to.be.false; | ||
| }); | ||
| it('consumers can prevent close', async () => { |
There was a problem hiding this comment.
Suggested change
| it('consumers can prevent close', async () => { | |
| it('prevent close', async () => { |
| var(--spectrum-tabs-focus-indicator-gap) | ||
| ) * -1 | ||
| ); | ||
| var( |
There was a problem hiding this comment.
This shouldn't be a part of this PR. Can you make sure this PR is clean with only related files
|
For larger text the UI is getting distorted. Can you please confirm this with design and update the necessary css changes for this! This will require a 
Also for documentation site, the demo is breaking. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create alert-banner component
Related issue(s)
Motivation and context
How has this been tested?
You can check out the component at alert-banner storybook
Check out usage information on alert-banner docs site
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.