-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native change event for hiddenSelect #6320
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Robert Snow <snowystinger@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like one of the Picker tests is failing. Have you looked into it?
Will look into it this weekend yeah. |
Been struggling to find out why this line causes that Picker test to fail:
I've added a story in the Picker story where you can debug the test. I cannot reproduce it manually. Will do another attempt later on. Another thing i've realised is that in the react-spectrum/packages/@react-aria/select/src/HiddenSelect.tsx Lines 135 to 168 in d7b7b35
|
Closes #6217
✅ Pull Request Checklist:
📝 Test Instructions:
yarn jest packages/@react-aria/select/test/HiddenSelect.test.tsx -t "should trigger onChange"
🧢 Your Project: