Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade clsx to v2.0.0 #5487

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Upgrade clsx to v2.0.0 #5487

merged 1 commit into from
Nov 28, 2023

Conversation

reidbarber
Copy link
Member

Closes #5483

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LFDanLu LFDanLu closed this Nov 28, 2023
@LFDanLu LFDanLu reopened this Nov 28, 2023
@rspbot
Copy link

rspbot commented Nov 28, 2023

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Nov 28, 2023
ktabors
ktabors approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs pages that use this still render and look correct.

LFDanLu
LFDanLu approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, classnames still seem well formed

@reidbarber reidbarber merged commit fa00e0d into main Nov 28, 2023
26 checks passed
@reidbarber reidbarber deleted the update-clsx branch November 28, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error with Webpack Module Federation because of old "clsx" dependency
4 participants
@reidbarber @rspbot @ktabors @LFDanLu