Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ligatures in monospace code blocks. #414

Conversation

sparecycles
Copy link

Description

turns off font ligatures in code blocks.

Related Issue

#413

Motivation and Context

It looks bad and is harder to read.

How Has This Been Tested?

In the brower, via dev-tools on the class declaration in question.

Screenshots (if appropriate):

image

Note font-variant-ligatures: no-common-ligatures does not help.
image

(also note the screen-shot text was also edited in dev-tools, I don't remember where I found the original issue).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed. 馃

@sparecycles
Copy link
Author

I don't understand the CI failure, if it's checking out pull/414/merge
image

then it shouldn't need to pull the branch specifically
image

and it can't find it because it's in my fork. Does this project not accept pull requests from forked repos?

@solimant solimant changed the base branch from dev to main February 15, 2024 00:04
src/components/layout.css Outdated Show resolved Hide resolved
Copy link
Contributor

@solimant solimant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 馃檹馃徏

@solimant solimant changed the base branch from main to disable-ligatures-in-code-blocks February 15, 2024 00:08
@solimant solimant merged commit 8f9f8b2 into adobe:disable-ligatures-in-code-blocks Feb 15, 2024
1 of 2 checks passed
solimant added a commit that referenced this pull request Feb 15, 2024
* disable ligatures in monospace code blocks.

* Fix ordering

---------

Co-authored-by: Adam Freidin <adam.freidin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants