Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Commit

Permalink
Introducing a buildtype to config (#14369)
Browse files Browse the repository at this point in the history
* adding a buildtype as prerelease and switching back the environemnt to production as the analytics server expects that

* switching the environment actually to production
  • Loading branch information
vickramdhawal authored and swmitra committed May 29, 2018
1 parent 4300f5a commit 04c4bb3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 2 additions & 1 deletion src/brackets.config.dev.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"analyticsDataServerURL" : "https://cc-api-data-stage.adobe.io/ingest",
"serviceKey" : "brackets-service",
"environment" : "stage",
"update_info_url" : "https://s3.amazonaws.com/files.brackets.io/updates/prerelease/<locale>.json"
"update_info_url" : "https://s3.amazonaws.com/files.brackets.io/updates/prerelease/<locale>.json",
"buildtype" : "dev"
}
3 changes: 2 additions & 1 deletion src/brackets.config.dist.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"analyticsDataServerURL" : "https://cc-api-data.adobe.io/ingest",
"serviceKey" : "brackets-service",
"environment" : "production",
"update_info_url" : "https://getupdates.brackets.io/getupdates/"
"update_info_url" : "https://getupdates.brackets.io/getupdates/",
"buildtype" : "production"
}
5 changes: 3 additions & 2 deletions src/brackets.config.prerelease.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"healthDataServerURL" : "https://health.brackets.io/healthDataLog",
"analyticsDataServerURL" : "https://cc-api-data.adobe.io/ingest",
"serviceKey" : "brackets-service",
"environment" : "prerelease",
"update_info_url" : "https://s3.amazonaws.com/files.brackets.io/updates/prerelease/<locale>.json"
"environment" : "production",
"update_info_url" : "https://s3.amazonaws.com/files.brackets.io/updates/prerelease/<locale>.json",
"buildtype" : "prerelease"
}
2 changes: 1 addition & 1 deletion src/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ define(function (require, exports, module) {
if (isDevBuild) {
additionalGlobals.BUILD_TYPE = strings.DEVELOPMENT_BUILD;
} else {
if (brackets.config.environment === 'production') {
if (brackets.config.buildtype === 'production') {
additionalGlobals.BUILD_TYPE = strings.RELEASE_BUILD;
} else {
additionalGlobals.BUILD_TYPE = strings.PRERELEASE_BUILD;
Expand Down

0 comments on commit 04c4bb3

Please sign in to comment.