Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation to stl.h #56

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

andreondra
Copy link
Contributor

Note: WIP PR.
Questions:

  1. Is the block comment style alright? I like the @param variant more.
  2. Is the inline comment style alright? I think the \\\< is more readable than previous variant.

@andreondra andreondra marked this pull request as ready for review May 20, 2022 16:31
@andreondra
Copy link
Contributor Author

I'm not sure about the stl_write_quad_object function. It looks unused.

@hroncok
Copy link
Member

hroncok commented May 23, 2022

I'm not sure about the stl_write_quad_object function. It looks unused.

It appears so. I'd say we can either skip the docs or document it as unknown+unused+deprecated.

I could not find any user of the function via https://grep.app/search?q=stl_write_quad_object or https://github.com/search?q=stl_write_quad_object&type=code either -- it's all just copied definitions from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants