Added fail-if-invalid option - resolves issue #45. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
Apr 24, 2022
src/util.c
Outdated
Comment on lines
639
to
656
| if( | ||
| stl->stats.facets_w_1_bad_edge != 0 || | ||
| stl->stats.facets_w_2_bad_edge != 0 || | ||
| stl->stats.facets_w_3_bad_edge != 0 || | ||
| stl->stats.degenerate_facets != 0 || | ||
| stl->stats.edges_fixed != 0 || | ||
| stl->stats.facets_removed != 0 || | ||
| stl->stats.facets_added != 0 || | ||
| stl->stats.backwards_edges != 0 || | ||
| stl->stats.normals_fixed != 0 || | ||
| ( | ||
| !reverse_all_flag && | ||
| stl->stats.facets_reversed != 0 | ||
| ) | ||
| ) | ||
| return 1; | ||
| else | ||
| return 0; |
There was a problem hiding this comment.
Two questions:
- Can the
if conditional: return 1, else return 0construct be replaced withreturn conditionalin C? - What does the function return? It returns 1 (aka true) when the STL was invalid? In that case should the name reflect that?
stl_check_resultsdoe snot really tell which way it works. I would expect it to return 1 when the STl was valid. We could either flip the values or rnema it, e.g. tostl_was_invalid.
There was a problem hiding this comment.
First question: yes, good point. I actually don't know why I thought it would me more readable inside the if statement.
Second question: Alright, renamed.
hroncok
reviewed
Apr 24, 2022
src/admesh.c
Outdated
| @@ -450,7 +456,8 @@ redistribute it under certain conditions. See the file COPYING for details.\n") | |||
| } | |||
|
|
|||
| stl_stats_out(&stl_in, stdout, input_file); | |||
|
|
|||
| if(fail_if_invalid_flag && stl_check_results(&stl_in, reverse_all_flag)) | |||
There was a problem hiding this comment.
If we do the reverse_all_flag if test outside of stl_check_results, then the function is more reusable outside of this main. WDYT?
Somethign like:
Suggested change
| if(fail_if_invalid_flag && stl_check_results(&stl_in, reverse_all_flag)) | |
| if(fail_if_invalid_flag && !reverse_all_flag && stl_check_results(&stl_in)) |
There was a problem hiding this comment.
The reason is we still want to check other stats for validity even if we explicitly reverse facets. So (just reporting our IRL discussion) we will pass a number of facets that should be reversed and check that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new CLI option to set a non-zero exit code if there are any errors detected in the file as in issue #45.