Added deep copy utility for stl_file. #50
Conversation
|
|
||
| if(src->v_shared != NULL){ | ||
|
|
||
| dst->v_shared = (stl_vertex*) calloc((dst->stats.number_of_facets / 2), sizeof(stl_vertex)); |
There was a problem hiding this comment.
The "half the size" thing might benefit from a comment.
There was a problem hiding this comment.
I just copied the allocation from the stlinit.h to get the right size, so I'm not sure about it myself but I agree a comment would be good. I suggest adding the comment to the struct member/init routine, because this is not the only occurrence of the v_shared. I have the stl.h docs almost ready in my fork, so if you know the reason for the size, I will add the information to the documentation.
There was a problem hiding this comment.
If I had to guess, it might have something to do with the fact that one edge belongs to 2 facets? No idea without reading the code. My idea for the comment was something like /* Mimic function X from stlinit.c */
src/util.c
Outdated
| if(src->facet_start != NULL){ | ||
|
|
||
| dst->facet_start = (stl_facet*)calloc(dst->stats.number_of_facets, sizeof(stl_facet)); | ||
| if(dst->facet_start == NULL) perror("stl_copy"); |
There was a problem hiding this comment.
We should probably set the exit flag here as well and return early?
There was a problem hiding this comment.
Good idea, I'd return error on every allocation failure to guarantee data integrity when returning success.
|
@gladk If we are to add a small test program (in c) that uses this and exports various different STLs would you be able to help us wrap it in cmaketests to verify which files are identical and which are different? |
|
Yes, sure! Please commit this test program here, so I will integrate this change into this pull request. |
|
@gladk How should the test program look like? Probably a standalone C code that takes a STL filename as an argument, opens and copies the file, runs a series of repairs and then export the copied mesh for comparison using CMakeTest or should the assertions be done directly in the test program? Like comparing the internal stl_file structures etc. Please tell what's the best for you to work with :). |
The function allows to copy stl_file and create an independent instance. Some members are not copied, because they are used only internally by some procedures (see comments).