Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type.setClient(c) for consistency and ... #77

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use type.setClient(c) for consistency and ... #77

wants to merge 4 commits into from

Commits on Nov 16, 2020

  1. Use type.setClient(c) for consistency and ... 

    There are several Type(s) that have sub-types, and it was inconsistent.
The goal here is to use type.setClient(c) every time, and if there
are sub-types, loop through them and use their subType.setClient(c).
Additionally, when possible, set the parent object.
(i.e.) Board <-> List <-> Card <-> CheckList <-> CheckItem

Used the `_, item` for range, as the code is much cleaner. (and maybe
easier to understand).

Also, minor "lint" change on board_test.go
    @TJM
    TJM committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    d1fba6a View commit details
    Browse the repository at this point in the history

  2. fix: Card.setClient should set List and Board

    @TJM
    TJM committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    ee122a1 View commit details
    Browse the repository at this point in the history

  3. feat: add queryCache for GetBoard and GetList

    @TJM
    TJM committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    a9163e2 View commit details
    Browse the repository at this point in the history

  4. Lets not pass EnableCache to Trello :)

    @TJM
    TJM committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    7ae07ad View commit details
    Browse the repository at this point in the history