Skip to content

Commit

Permalink
Makefile, .github/workflows: update golangci-lint to v1.44.2
Browse files Browse the repository at this point in the history
Also drop the GH action skip-go-installation option which was removed in
v3 of the golangci-lint action (see
https://github.com/golangci/golangci-lint-action#compatibility) and
switch to skip-cache as the new catch-all (suggested by Robin).

Signed-off-by: Tobias Klauser <tobias@cilium.io>
  • Loading branch information
tklauser authored and aditighag committed Jan 3, 2023
1 parent 99c1c3c commit 6f3e896
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/go.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@ jobs:
- name: Run static checks
uses: golangci/golangci-lint-action@b517f99ae23d86ecc4c0dec08dcf48d2336abc29
with:
version: v1.43.0
version: v1.44.2
args: --config=.golangci.yml --verbose
skip-go-installation: true
skip-pkg-cache: true
skip-build-cache: true
skip-cache: true

- name: Check module vendoring
run: |
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ TEST_TIMEOUT ?= 5s
RELEASE_UID ?= $(shell id -u)
RELEASE_GID ?= $(shell id -g)

GOLANGCILINT_WANT_VERSION = 1.42.1
GOLANGCILINT_WANT_VERSION = 1.44.2
GOLANGCILINT_VERSION = $(shell golangci-lint version 2>/dev/null)

$(TARGET):
Expand Down

0 comments on commit 6f3e896

Please sign in to comment.