feat(link-box): added Linkbox.Link to raised components inside the box #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acd02
reviewed
May 16, 2024
| It will raise their `z-index` to stay above the main link of your `LinkBox`. |
There was a problem hiding this comment.
Maybe we should clarify that a single LinkBox can contain only one LinkBox.Link
acd02
approved these changes
May 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
==========================================
- Coverage 97.64% 97.63% -0.02%
==========================================
Files 748 749 +1
Lines 5869 5873 +4
Branches 2100 2100
==========================================
+ Hits 5731 5734 +3
- Misses 136 137 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
soykje
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK: #2132
Description, Motivation and Context
We were not sure about using css selectors to raise nested links/elements on top of the overlay. Instead we introduce
LinkBox.Raisedto explicitely flag which components should remain on top.Types of changes