SX: implement styles rehydration #4039
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
5a40cf7
to
4138138
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
4138138
to
d21e158
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
d21e158
to
573dd0a
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
573dd0a
to
b974b64
Compare
vercel
bot
temporarily deployed
to
Preview – universe-sx-tailwind-website
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
b974b64
to
e7a541b
Compare
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
4 times, most recently
from
712c4b6
to
0a79ab3
Compare
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
3 times, most recently
from
dcc910e
to
bfbd00b
Compare
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
2 times, most recently
from
2ba3514
to
e449cb8
Compare
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
e449cb8
to
3e97da0
Compare
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
2 times, most recently
from
96070ed
to
52dc20e
Compare
I have these changes sitting locally for a very long time, and it's time to offload them. The idea behind the styles rehydration is very simple: we collect all existing styles from `<style data-adeira-sx />` (once) and use this information later for deciding whether the styles should be injected or not (this is what I call rehydration). The difference from the current solution is that we do it only once and we don't have to go through all the styles everytime there is something to inject. Motivation for this change is performance: this should significantly improve the runtime style perf + be much easier to deal with (for example, we are basically brute-forcing @at rules and pseudo rules now). Note: this is just a partial solution, there are other changes coming (custom styles printer and @at nodes/pseudo nodes optimization). Related issue: #1579
mrtnzlml
force-pushed
the
sx_rehydrate_styles
branch
from
52dc20e
to
ca47c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have these changes sitting locally for a very long time, and it's time
to offload them. The idea behind the styles rehydration is very simple:
we collect all existing styles from
<style data-adeira-sx />(once)and use this information later for deciding whether the styles should be
injected or not (this is what I call rehydration).
The difference from the current solution is that we do it only once and
we don't have to go through all the styles everytime there is something
to inject.
Motivation for this change is performance: this should significantly
improve the runtime style perf + be much easier to deal with (for
example, we are basically brute-forcing @at rules and pseudo rules now).
Note: this is just a partial solution, there are other changes coming
(custom styles printer and @at nodes/pseudo nodes optimization).
Related issue: #1579