Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint config: re-enable react/forbid-dom-props rule #2184

Merged
merged 2 commits into from Apr 9, 2021
Merged

Eslint config: re-enable react/forbid-dom-props rule #2184

merged 2 commits into from Apr 9, 2021

Conversation

mrtnzlml
Copy link
Member

@mrtnzlml mrtnzlml commented Apr 9, 2021 •
edited

It's been fixed in jsx-eslint/eslint-plugin-react#2961 and upgraded in #2172

Closes #2005

@mrtnzlml mrtnzlml requested a review from a team as a code owner April 9, 2021 14:38
@kodiakhq kodiakhq bot merged commit 4acf0ad into master Apr 9, 2021
@kodiakhq kodiakhq bot deleted the eslint_enable_react_forbid-dom-props branch April 9, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsanger michalsanger michalsanger approved these changes

@jaroslav-kubicek jaroslav-kubicek Awaiting requested review from jaroslav-kubicek

@tbergquist-godaddy tbergquist-godaddy Awaiting requested review from tbergquist-godaddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eslint rule 'react/forbid-dom-props' doesn't work well with 'fbt:param' or 'fbt:plural'
2 participants
@mrtnzlml @michalsanger