Skip to content

Commit

Permalink
Remove FBT Babel workarounds
Browse files Browse the repository at this point in the history
It should no longer be needed, see: facebook/fbt@ecc647d

There is another issue though in Eslint which needs to be fixed, see: adeira/universe#2005

adeira-source-id: 04788595362d400edf1d5f9e8f947d764ce361ef
  • Loading branch information
mrtnzlml authored and adeira-github-bot committed Mar 18, 2021
1 parent a88d0cb commit 5bfb1fd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 18 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
@@ -1,6 +1,7 @@
# Unreleased

- Our custom rule `adeira/no-internal-flow-type` has been migrated to official `flowtype/no-internal-flow-type` (https://github.com/gajus/eslint-plugin-flowtype/pull/469). There should be no changes in behavior.
- Rule `react/forbid-dom-props` has been temporarily disabled because it causes problems with [FBT](https://facebook.github.io/fbt/) tags, see: https://github.com/adeira/universe/issues/2005

# 5.1.0

Expand Down
10 changes: 1 addition & 9 deletions __tests__/__snapshots__/index.test.js.snap
Expand Up @@ -743,15 +743,7 @@ Object {
"react/destructuring-assignment": 0,
"react/display-name": 0,
"react/forbid-component-props": 0,
"react/forbid-dom-props": Array [
2,
Object {
"forbid": Array [
"class",
"for",
],
},
],
"react/forbid-dom-props": 0,
"react/forbid-elements": 0,
"react/forbid-foreign-prop-types": 0,
"react/forbid-prop-types": 0,
Expand Down
10 changes: 1 addition & 9 deletions ourRules.js
Expand Up @@ -361,15 +361,7 @@ module.exports = ({
'react/destructuring-assignment': OFF,
'react/display-name': OFF,
'react/forbid-component-props': OFF,
'react/forbid-dom-props': [
ERROR,
{
forbid: [
'class', // https://reactjs.org/docs/dom-elements.html#classname
'for', // https://reactjs.org/docs/dom-elements.html#htmlfor
],
},
],
'react/forbid-dom-props': OFF,
'react/forbid-elements': OFF,
'react/forbid-foreign-prop-types': OFF,
'react/forbid-prop-types': OFF,
Expand Down

0 comments on commit 5bfb1fd

Please sign in to comment.