Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollup type definitions #2301

Merged
merged 3 commits into from Feb 10, 2021
Merged

rollup type definitions #2301

merged 3 commits into from Feb 10, 2021

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Feb 10, 2021 •
edited

https://api-extractor.com/
Inspired by puppeteer/puppeteer#6837

With this PR, we'll ship a single lib/index.d.ts file, instead of many .d.ts files.

Pros:

  • Private values/types/APIs cannot be imported anymore
    • Will make it easier to avoid breaking changes with future releases.
  • Cleaner intellisense since we'll have fewer types available to import image
  • Smaller package size
  • Could be used in the future to automatically generate documentation

@nstepien nstepien self-assigned this Feb 10, 2021
@nstepien nstepien marked this pull request as ready for review February 10, 2021 18:59
nstepien
nstepien commented Feb 10, 2021
View reviewed changes
src/Cell.tsx
@@ -129,4 +130,4 @@ function Cell<R, SR>({
);
}

export default memo(forwardRef(Cell)) as <R, SR = unknown>(props: CellRendererProps<R, SR> & React.RefAttributes<HTMLDivElement>) => JSX.Element;
export default memo(forwardRef(Cell)) as <R, SR = unknown>(props: CellRendererProps<R, SR> & RefAttributes<HTMLDivElement>) => JSX.Element;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
🤷

amanmahajan7
amanmahajan7 previously approved these changes Feb 10, 2021
View reviewed changes
src/Row.tsx Outdated Show resolved Hide resolved
@nstepien @amanmahajan7
Update src/Row.tsx
fa6e92b 
Co-authored-by: Aman Mahajan <amahajan@stratag.com>
@nstepien nstepien enabled auto-merge (squash) February 10, 2021 20:50
@nstepien nstepien merged commit 8e25e00 into canary Feb 10, 2021
@nstepien nstepien deleted the api branch February 10, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanmahajan7 amanmahajan7 amanmahajan7 approved these changes

Assignees

@nstepien nstepien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nstepien @amanmahajan7