Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interlok 4134 correct null implementations v4 #1227

Open
wants to merge 2 commits into
base: develop-v4
Choose a base branch
from

Conversation

jameswickham
Copy link
Contributor

Motivation

Updating the interface so the two List methods have default implementations that will throw a UnsupportedOperationException exception if called.

This is to replace having null implementions defined within the classes that don't need them.

Modification

RetryStore interface and the classes that implement it.

PR Checklist

  • been self-reviewed.
  • Added javadocs for most classes and all non-trivial methods
  • [n/a] Added supporting annotations (like @XStreamAlias / @ComponentProfile)
  • [n/a] Added DefaultValue annotation when there is a default value (e.g. @DefaultValue('true'))
  • [n/a] Added validation annotation (@NotNull...) when required and add @Valid when nested class has some validation
  • [n/a] Checked that @NotNull and @notblank annotations have a meaningful message when appropriate.
  • [n/a] Checked that new 3rd party dependencies are appropriately licensed
  • [n/a] Added comments explaining the "why" and the intent of the code wherever it would not be obvious for an unfamiliar reader
  • [n/a] Added unit tests or modified existing tests to cover new code paths
  • [n/a] Tested new/updated components in the UI and at runtime in an Interlok instance
  • [n/a] Reviewed java class members so that missing annotations are added (InputFieldDefault/ComponentProfile etc)
  • [n/a] Checked that javadoc generation doesn't report errors
  • [n/a] Checked the display of the component in the UI
  • [n/a] Remove any config/license annotations
  • [n/a] Check the gradle build file to make sure the dependencies section is more explicit "implementation/api".

Result

What's the end result for the user

Testing

How can I test this if I'm reviewing this.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (bbfe19d) 93.39% compared to head (b9f3bbf) 93.45%.

Additional details and impacted files
@@               Coverage Diff                @@
##             develop-v4    #1227      +/-   ##
================================================
+ Coverage         93.39%   93.45%   +0.06%     
- Complexity        11127    11128       +1     
================================================
  Files              1086     1086              
  Lines             29876    29876              
  Branches           2105     2105              
================================================
+ Hits              27904    27922      +18     
+ Misses             1542     1520      -22     
- Partials            430      434       +4     
Files Changed Coverage Δ
...is/core/http/jetty/retry/FilesystemRetryStore.java 95.60% <ø> (+2.05%) ⬆️
...com/adaptris/core/http/jetty/retry/RetryStore.java 71.42% <0.00%> (-28.58%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant