Merge pull request #957 from adamtheturtle/rm-unnecessary-isinstance

adamtheturtle · May 10, 2024 · 6bfcd04 · 6bfcd04
2 parents 27f5b5a + 935e745
commit 6bfcd04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/src/requests_mock_flask/__init__.py b/src/requests_mock_flask/__init__.py
@@ -170,10 +170,7 @@ def _responses_callback(
 
     response = test_client.open(environ_builder.get_request())
 
-    result_headers: dict[str, str | int | bool | None] = dict(
-        response.headers,
-    )
-    return (response.status_code, result_headers, bytes(response.data))
+    return (response.status_code, dict(response.headers), bytes(response.data))
 
 
 def _httpretty_callback(
@@ -218,10 +215,7 @@ def _httpretty_callback(
     )
     response = test_client.open(environ_builder.get_request())
 
-    result_headers: dict[str, str | int | bool | None] = dict(
-        response.headers,
-    )
-    return (response.status_code, result_headers, response.data)
+    return (response.status_code, dict(response.headers), response.data)
 
 
 def _requests_mock_callback(

diff --git a/tests/test_requests_mock_flask.py b/tests/test_requests_mock_flask.py
@@ -872,8 +872,7 @@ def test_request_needs_data(mock_ctx: _MockCtxType) -> None:
     @app.route("/")
     def _() -> str:
         assert request.mimetype == "application/json"
-        request_json: dict[str, str] = request.get_json()
-        assert isinstance(request_json, dict)
+        request_json = request.get_json()
         return str(request_json["hello"])
 
     test_client = app.test_client()
@@ -1025,7 +1024,6 @@ def _() -> Response:
         assert request.cookies["frasier"] == "crane"
         assert request.cookies["frasier2"] == "crane2"
         response.data = "Hello, World!"
-        assert isinstance(response, Response)
         return response
 
     test_client = app.test_client()