Fix upload to PyPI #302
Merged
Fix upload to PyPI #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple things failed at once: 1. Link to readme was lost during conversion to `pyproject.toml` in f668317. This commit restores it. 2. PyPI only accepts rst/markdown/txt, so undo conversion of readme to AsciiDoc that was done in 55191a7 3. twine has a bug that prevents upload from working without readme: pypa/twine#908 Also run `twine check` on CI to detect `pyproject.toml` metadata errors earlier
slonopotamus
force-pushed
the
fix-pypi-upload
branch
from
41f041f
to
6840995
Compare
|
Looks like everything works properly again: https://pypi.org/project/ue4-docker/0.0.105/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple things failed at once:
pyproject.tomlin f668317. This commit restores it.twine checkpypa/twine#908 and Does twine treat long_description as a mandatory field? pypa/twine#960Also run
twine checkon CI to detectpyproject.tomlmetadata errors earlier