Add .tar.7z support #756
Closed
Add .tar.7z support #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhathcock
requested changes
Sep 7, 2023
| @@ -105,7 +105,7 @@ public static SevenZipArchive Open(Stream stream, ReaderOptions readerOptions = | |||
| /// <param name="srcStream"></param> | |||
| /// <param name="options"></param> | |||
| internal SevenZipArchive(SourceStream srcStream) | |||
| : base(ArchiveType.SevenZip, srcStream) { } | |||
| : base(ArchiveType.Tar, srcStream) { } | |||
There was a problem hiding this comment.
This isn't right. We can't change archive types.
What do tars for gz and bz2 do?
There was a problem hiding this comment.
The GZipArchive does the same thing, that was the only way that the test was able to succeed for both GZip and SevenZip
There was a problem hiding this comment.
/// <summary>
/// Constructor with a SourceStream able to handle FileInfo and Streams.
/// </summary>
/// <param name="srcStream"></param>
/// <param name="options"></param>
internal GZipArchive(SourceStream srcStream)
: base(ArchiveType.Tar, srcStream) { }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate for #751
I used Ubuntu subsystem on Windows to create a .tar.7z file, and was able to open and read it via the test