Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ignoring archive files after processing of internal archive #344

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codeFather2
Copy link

Fix #343

Add original folder named OriginalMacOsChild
Add assertion to test (comparison of quantity)
@KvanTTT
Copy link

KvanTTT commented Feb 23, 2018

@adamhathcock when are you going to merge this PR?
@codeFather2 could you resolve merge conflicts?

@adamhathcock
Copy link
Owner

This is really about non-compressed internal archives which is same as #86 I believe

@codeFather2
Copy link
Author

codeFather2 commented May 2, 2018

In this case, the problem was that if there is a file in the child archive, the size of which without compression is longer than the remaining length of the parent archive, then after reading the header of this file, the Reader moved to the end of the parent archive, skipping subsequent files. This is due to the fact that when compressing the file header from the child archive, it was placed before the header of the child archive itself, and then it was duplicated inside. My corrections allowed me to bypass this error, without damage to the usual archives. Without these changes, the files enclosed in the child archive will be uncompressed successfully, but files that follow the child archive will be ignored. The problem was noticed when using the archiver on Mac OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants