Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Folders to ZipArchive #342

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Folders to ZipArchive #342

wants to merge 3 commits into from

Conversation

dos-ise
Copy link

@dos-ise dos-ise commented Jan 18, 2018

Add Folders to ZipArchive like in dotnetzip. Not yet ready

adamhathcock
adamhathcock reviewed Jan 18, 2018
View reviewed changes
Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so this over using the existing extension methods?

@dos-ise
Copy link
Author

dos-ise commented Jan 18, 2018

You mean the AddAllFromDirectory Extension?
This should create an empty folder in the zip file instead adding an folder and all of its contetn.

Its a behavior from dotnetzip we use quit alot.

@adamhathcock
Copy link
Owner

I couldn't quite tell what you were going for. So you want the ability to add directory entries?

@dos-ise
Copy link
Author

dos-ise commented Jan 19, 2018

Correct, I added a test to clarify for what I am trying to achieve. Sorry for the misleading commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhathcock adamhathcock adamhathcock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dos-ise @adamhathcock