Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion...
Add a rule to recommend using generator expressions rather than list comprehensions when they are only used for iteration by a for loop e.g:
This is an inefficient pattern which seems to crop up every now and again.
The logic for this is similar to C419:
iterable
is 1'000 items long, then a 1'000 item list will be created in order for thefor
loop to iterate over which is inefficient.