Issue detect useless generator pattern #520
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorianturba
reviewed
Jul 30, 2023
dorianturba
reviewed
Jul 30, 2023
| @@ -199,6 +200,21 @@ def run(self) -> Generator[tuple[int, int, str, type[Any]], None, None]: | |||
| type(self), | |||
| ) | |||
|
|
|||
| elif ( | |||
| node.func.id == "sorted" | |||
There was a problem hiding this comment.
From the original issue:
the (a for a in b) generator construct doesn't seem particularly useful and just adds an unnecessary context switch of the generator.
I think we can check every generator, not only those inside sorted call.
This mean that the check would be only the isinstance of node as ast.GeneratorExp and isinstance of node.elt as ast.Name. What do you think?
There was a problem hiding this comment.
You should be right.
We should verify if the Generator do something, in all cases, not only for sorted call.
I need to put this on my desktop : KISS 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress