pre-commit-hooks: remove language_version #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as psf/black#2430.
|
this value is still correct, I don't really agree with the premise of psf/black#2430 |
adamchainz
pushed a commit
that referenced
this pull request
Aug 16, 2023
This enables `default_language_version` stanzas in consuming `.pre-commit-config.yaml` files to take precedence. This change is the same as psf/black#2430, see that PR for full context on why this is beneficial. This was previously PR'ed to this project as #144. It was closed at the time so my company has been keeping a fork of this project with the patch applied. With the new maintainership, I wanted to ask whether this change would be accepted at this time. Thanks in advance for taking a look, happy to answer any questions.
adamchainz
pushed a commit
to maxb2/blacken-docs
that referenced
this pull request
Aug 16, 2023
This enables `default_language_version` stanzas in consuming `.pre-commit-config.yaml` files to take precedence. This change is the same as psf/black#2430, see that PR for full context on why this is beneficial. This was previously PR'ed to this project as adamchainz#144. It was closed at the time so my company has been keeping a fork of this project with the patch applied. With the new maintainership, I wanted to ask whether this change would be accepted at this time. Thanks in advance for taking a look, happy to answer any questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as psf/black#2430.