Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Read the Docs bulid failing #3255

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Fix Read the Docs bulid failing #3255

merged 2 commits into from
Aug 10, 2020

Conversation

ciscorn
Copy link

@ciscorn ciscorn commented Aug 7, 2020

This PR will fix the following errors:

@jepler
Copy link
Member

jepler commented Aug 7, 2020

Is the change to the ulab submodule itself intended? Are these changes merged into ulab?

@ciscorn
Copy link
Author

ciscorn commented Aug 7, 2020

@jepler
Not intended, but it is the HEAD of ulab's origin/master that has the latest stubs. So it should be ok.

jepler
jepler previously approved these changes Aug 7, 2020
@ciscorn
Copy link
Author

ciscorn commented Aug 7, 2020

The CI failed with the latest ulab stubs. It seems we have to wait for autoapi to support the @overload decorator. (readthedocs/sphinx-autoapi#239).

For now, I reverted the update of the ulab submodule to make this PR pass the test.

@ciscorn ciscorn requested a review from jepler August 8, 2020 02:11
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jepler jepler merged commit ce911c5 into adafruit:main Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants