Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gamepad examples #76

Merged
merged 1 commit into from Aug 21, 2021
Merged

fix gamepad examples #76

merged 1 commit into from Aug 21, 2021

Conversation

FoamyGuy
Copy link
Contributor

resolves #71

The changes in this PR:

  • rename gamepad.py to hid_gamepad.py
  • change the usage imports in the other examples to match the new name
  • add note and guide link about needing to setup the gamepad HID device
  • fix the adafruit_seesaw import. During testing I noticed that it was not able to be initialized properly using the code that was there before.

I tested hid_gamepad.py and the two examples that make use of it on a Feather RP2040 with 7.0.0 alpha6

@FoamyGuy
Copy link
Contributor Author

Hmmm, pre-commit passed successfully when I ran it locally:

❯ pre-commit run --all-files
black....................................................................Passed
reuse....................................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
pylint (library code)....................................................Passed
pylint (examples code)...................................................Passed

Perhaps there are differing versions of pylint or something else different about my environment. I'll try to look into why it failed in the actions check.

@FoamyGuy
Copy link
Contributor Author

Indeed the PyLint failure seems to be related to version 2.10 of PyLint which was released a few hours ago https://github.com/PyCQA/pylint/releases/tag/v2.10.0

I installed that version locally and now my local pre-commit fails the same way that the one inside the actions run is.

To verify I installed version 2.9.6 which was the previous release version and with that version pre-commit runs and completes successfully.

@FoamyGuy
Copy link
Contributor Author

More information about the pylint failure can be found here: pylint-dev/pylint#4883

@dhalbert
Copy link
Collaborator

dhalbert commented Aug 21, 2021 •
edited

pylint 2.10.1 with a fix for this (pylint-dev/pylint#4884) has been released on pypi.org. I re-ran the CI and it works fine now.

dhalbert
dhalbert approved these changes Aug 21, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@dhalbert dhalbert merged commit 59c3465 into adafruit:main Aug 21, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 27, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@f879b24)
e25350f 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.2.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#5 from lesamouraipourpre/vertical-scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.4.0 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#8 from lesamouraipourpre/vertical-scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#13 from lesamouraipourpre/vertical-scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.5.0 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#23 from lesamouraipourpre/vertical-scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV2640 to 1.1.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV2640#12 from jerryneedell/jerryn_saola

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.2.0 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#12 from lesamouraipourpre/vertical-scroll

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.4.0 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#13 from lesamouraipourpre/vertical-scroll
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#12 from lesamouraipourpre/docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.0.3 from 8.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#132 from adafruit/dhalbert-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.12.0 from 1.11.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#47 from FoamyGuy/remove_dial_and_annotation

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.1.1 from 5.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#79 from adafruit/tannewt-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#76 from FoamyGuy/rename_gamepad_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#28 from Neradoc/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix gamepad examples
2 participants
@FoamyGuy @dhalbert