Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miniMQTT compatibility and native_networking examples #37

Merged
merged 13 commits into from Jan 27, 2022
Merged

Fix miniMQTT compatibility and native_networking examples #37

merged 13 commits into from Jan 27, 2022

Conversation

askpatrickw
Copy link
Contributor

@askpatrickw askpatrickw commented Jan 22, 2022 •
edited

  • added ssl_context to creation of MQTT() <-- This is the main fix
  • changed minimqtt import to match minimqtt samples
  • Changed secrets['key'] to secrets['device_sas_key'] because we want the IoT Central DEVICE SAS Key not the API Key, or the IoT Central Application SAS key
  • Moved existing examples into examples/esp32spi subfolder, inline with minimqtt samples
  • Created examples/native_networking folder
  • Created and tested native_networking examples. All tested on Metro ESP32-S2 and passed.
  • updated .gitignore with full set of "ignores" as recommended by VSCode's extension
  • Python coding style changes as per sourcery
  • Updated docs: added esp32spi and native networking imports, updated the dependencies in the init.py docstring
  • Added blank line after description before params in docstring to fix layout issues where parameters were not formatted properly in Sphinx HTML output
  • Fixed Doc Build Failure as FoamyGuy suggests in the open issue: Sphinx Build Error: ... can only concatenate str (not "__qualname__") to str #38

ToDo:

  • Test ESP32SPI examples.
    NOTE: I do not have an ESP32SPI board, if someone else could try at least the simpletest examples, that would be awesome.

@askpatrickw askpatrickw added the enhancement New feature or request label Jan 22, 2022
@askpatrickw askpatrickw linked an issue Jan 22, 2022 that may be closed by this pull request
Tracking dependency changes for ESP32-S2 and CP7 #21
Closed
7 tasks
@askpatrickw askpatrickw mentioned this pull request Jan 22, 2022
Closed
7 tasks
@askpatrickw askpatrickw marked this pull request as draft January 22, 2022 08:02
@askpatrickw askpatrickw self-assigned this Jan 22, 2022
brentru
brentru reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the neopixel stuff from simple examples. I find these "extras" confusing when learning a new library.

I'd prefer to keep this in, modify the behavior of the examples as little as possible.

I am using adafruit_requests and the adafruit_io time api to set time. Is this cool as a general approach?

Perfectly fine

README.rst Outdated Show resolved Hide resolved
@askpatrickw askpatrickw marked this pull request as ready for review January 25, 2022 05:24
@askpatrickw askpatrickw requested review from brentru and a team January 26, 2022 00:19
@brentru
Copy link
Member

brentru commented Jan 26, 2022

@askpatrickw Did you test this on the PyPortal (or any "AirLift" hardware)?

@askpatrickw
Copy link
Contributor Author

No. Only on a MetroS2. I don't have those other boards.

brentru
brentru requested changes Jan 26, 2022
View reviewed changes
README.rst Outdated Show resolved Hide resolved
adafruit_azureiot/__init__.py Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@askpatrickw askpatrickw linked an issue Jan 27, 2022 that may be closed by this pull request
Sphinx Build Error: ... can only concatenate str (not "__qualname__") to str #38
Closed
@askpatrickw
Copy link
Contributor Author

OK @brentru I think I'm done. I can provide Azure API Keys for anyone who can test on an ESP32 Airlift.

@brentru brentru merged commit 4b72e22 into adafruit:main Jan 27, 2022
@askpatrickw askpatrickw deleted the add-ssl-context branch January 27, 2022 17:34
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 28, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e0933a7)
2a3130b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 1.1.0 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#28 from kattni/pypi
  > Updated docs link, updated python docs link, updated setup.py
  > First part of patch
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.0 from 2.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#37 from askpatrickw/add-ssl-context
  > Update Dependencies DOCSTRING
  > Update samples and docs
  > typo in the README
  > make SAS Key more specific
  > Fix miniMQTT compatibility and native_networking examples
  > Updated docs link, updated python docs link, updated setup.py
  > First part of patch
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.17.0 from 1.16.0:
  > Updated docs link, updated python docs link, updated setup.py
  > First part of patch
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#68 from FoamyGuy/transparency_and_label_bg

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Nunchuk, Adafruit_CircuitPython_AzureIoT, Adafruit_CircuitPython_DisplayIO_Layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees

@askpatrickw askpatrickw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@askpatrickw @brentru