Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add require_passed_checks input to control if should skip checks step #10

Merged
merged 2 commits into from Apr 5, 2021
Merged

Add require_passed_checks input to control if should skip checks step #10

merged 2 commits into from Apr 5, 2021

Conversation

alejandrohdezma
Copy link
Contributor

This new input will allow users to control wether failed checks should be taken into account when searching for the next updatable PR or not.

In order to maintain backwards-compatibility I have set the input as optional with a default value of true.

@coveralls
Copy link

coveralls commented Apr 1, 2021 •
edited

Pull Request Test Coverage Report for Build 719832918

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 622496972: 0.0%
Covered Lines: 82
Relevant Lines: 82
💛 - Coveralls

zhiyelee
zhiyelee approved these changes Apr 5, 2021
View reviewed changes
Copy link
Collaborator

@zhiyelee zhiyelee left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution @alejandrohdezma

src/lib/github.test.js Outdated Show resolved Hide resolved
arunshan
arunshan reviewed Apr 5, 2021
View reviewed changes
action.yml Show resolved Hide resolved
@zhiyelee zhiyelee merged commit 83c61e2 into adRise:master Apr 5, 2021
@zhiyelee
Copy link
Collaborator

zhiyelee commented Apr 6, 2021 •
edited

Published v0.5.0 with this change https://github.com/adRise/update-pr-branch/releases/tag/v0.5.0

Thanks @alejandrohdezma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiyelee zhiyelee zhiyelee approved these changes

@arunshan arunshan arunshan approved these changes

@yuhaoju yuhaoju Awaiting requested review from yuhaoju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alejandrohdezma @coveralls @zhiyelee @arunshan