Adapt changes for logger changed to construct

acumino · Jul 19, 2022 · d219d44 · d219d44
1 parent 2cc0e5d
commit d219d44
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/pkg/logger/logger.go b/pkg/logger/logger.go
@@ -98,7 +98,7 @@ func New(config *Config) (logr.Logger, error) {
 
 	zapLog, err := zapCfg.Build(zap.AddCallerSkip(1))
 	if err != nil {
-		return nil, err
+		return logr.Logger{}, err
 	}
 	return zapr.NewLogger(zapLog), nil
 }

diff --git a/pkg/testrunner/result/summary-poster_test.go b/pkg/testrunner/result/summary-poster_test.go
@@ -15,6 +15,7 @@
 package result
 
 import (
+	"github.com/go-logr/logr"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 
@@ -44,7 +45,7 @@ var _ = Describe("summary-poster", func() {
 		runs = append(runs, run)
 		items := parseTestrunsToTableItems(runs)
 		Expect(items).To(HaveLen(1))
-		slack, err := util.RenderTableForSlack(nil, items)
+		slack, err := util.RenderTableForSlack(logr.Logger{}, items)
 		Expect(err).ToNot(HaveOccurred())
 		Expect(slack).To(ContainSubstring(string(util.StatusSymbolSuccess)))
 		Expect(slack).ToNot(ContainSubstring(string(util.StatusSymbolNA)))
@@ -82,7 +83,7 @@ var _ = Describe("summary-poster", func() {
 		runs = append(runs, run)
 		items := parseTestrunsToTableItems(runs)
 		Expect(items).To(HaveLen(2))
-		slack, err := util.RenderTableForSlack(nil, items)
+		slack, err := util.RenderTableForSlack(logr.Logger{}, items)
 		Expect(err).ToNot(HaveOccurred())
 		Expect(slack).To(ContainSubstring(string(util.StatusSymbolSuccess) + util.SymbolOffset + string(util.StatusSymbolFailure)))
 		Expect(slack).ToNot(ContainSubstring(string(util.StatusSymbolNA)))

diff --git a/pkg/util/slack-table-post_test.go b/pkg/util/slack-table-post_test.go
@@ -15,6 +15,7 @@
 package util_test
 
 import (
+	"github.com/go-logr/logr"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 
@@ -55,7 +56,7 @@ var _ = Describe("Slack Table Post", func() {
 				StatusSymbol: util.StatusSymbolSuccess,
 			}
 			tis := []*util.TableItem{&ti}
-			table, err := util.RenderTableForSlack(nil, tis)
+			table, err := util.RenderTableForSlack(logr.Logger{}, tis)
 			Expect(err).ToNot(HaveOccurred())
 			Expect(table).To(ContainSubstring("(orange)"))
 			Expect(table).To(ContainSubstring("[para]"))