Don't require an Encoder type while constructing FramedWrite so we can be generic over the lifetime #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature/Bug Fix
PR Checklist
Check your PR fulfills the following:
Overview
This is a breaking change as it changes the signature of
FramedWrite
. This punts the responsibility of grabbing the type ofitem
towrite()
rather than upon construction, essentially allowing us to treat the item as:rather than the current:
The new signature of
FramedWrite
is now:rather than: