Add getters for &ServiceRequest
#2786
Merged
+15
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Tests for the changes have been added / updated.**no tests necessary; none for
parts_mut/into_parts
or other gettersOverview
Adds getters for cases when you only have a
&ServiceRequest
and need access to the inner parts.parts
: returns immutable refs to the inner request and payload. Non-owning counterpart tointo_parts
andparts_mut
.request
: just gives access to theHttpRequest
since there's not a lot you can do with a&Payload
currently.This allows access to parts of the
HttpRequest
not already covered by the existing getters. Additionally, this allowsFromRequest
ing types that don't require access to thePayload
, likeIdentity
. (ServiceRequest::extract
, while covering a similar use case, requires a&mut ServiceRequest
and thus isn't usable in this context.)No breaking changes.
Use case mentioned in #2175, but it doesn't seem like the associated issue was ever opened.