Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guarantee ordering of header map get_all #2467

Merged
merged 2 commits into from Nov 28, 2021
Merged

guarantee ordering of header map get_all #2467

merged 2 commits into from Nov 28, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Nov 28, 2021 •
edited

PR Type

Doc / Tests

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Effectively a doc change + tests.

closes #2466

@robjtede robjtede added A-http project: actix-http B-semver-patch labels Nov 28, 2021
@robjtede robjtede marked this pull request as ready for review November 28, 2021 00:18
@robjtede
Copy link
Member Author

cc @mkantor

@robjtede robjtede requested a review from a team November 28, 2021 01:21
@robjtede robjtede merged commit 3924309 into master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
A-http project: actix-http B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider guaranteeing the iteration order of HeaderMap::get_all
2 participants
@robjtede @popzxc