Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement io-uring for actix-files #2408

Merged
merged 36 commits into from Nov 22, 2021
Merged

implement io-uring for actix-files #2408

merged 36 commits into from Nov 22, 2021

Conversation

fakeshadow
Copy link
Contributor

@fakeshadow fakeshadow commented Oct 13, 2021 •
edited by robjtede

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

@fakeshadow fakeshadow added A-files project: actix-files B-semver-norelease change that does not require a release A-web project: actix-web B-semver-minor and removed B-semver-norelease change that does not require a release labels Oct 18, 2021
@fakeshadow
Copy link
Contributor Author

CI fail would be fixed by actix/actix-net#395

@fakeshadow fakeshadow linked an issue Oct 25, 2021 that may be closed by this pull request
add io-uring support into actix-files #2404
Closed
@robjtede
Copy link
Member

robjtede commented Nov 9, 2021

CI will probably need a job split out for Linux and separate aliases like in actix-net.

@fakeshadow
Copy link
Contributor Author

We can skip most of the io-uring feature besides for actix-files for now. It's already tested by actix-net and we don't guarantee it would work besides actix-files.
The io-uring feature on actix-web is just to active actix-server/io-uring

@robjtede robjtede merged commit dd347e0 into master Nov 22, 2021
@robjtede robjtede deleted the feat/io-uring branch November 22, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-files project: actix-files A-web project: actix-web B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add io-uring support into actix-files
2 participants
@fakeshadow @robjtede