remove cookie support from -http #2065
Merged
+1,337
−568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
added
A-http
This comment has been minimized.
This comment has been minimized.
|
Sweet! |
robjtede
force-pushed
the
no-cookies-for-you
branch
from
9a8e8d0 to
6984120
Compare
robjtede
force-pushed
the
no-cookies-for-you
branch
from
6984120 to
adc94f5
Compare
5 tasks
near-bulldozer bot
pushed a commit
to near/nearcore
that referenced
this pull request
May 5, 2021
Fixes #4240 - Update `actix-web` to latest beta `v4.0.0-beta.6` - Migrate to using `awc` directly instead of previously re-exported `actix_web::client` - Pulled upstream updates for [`near/actix-extras`](https://github.com/near/actix-extras) and updated `actix-web` dependency on all crates (actix/actix-extras@master...near:actix-web-4-beta.6) - Reimplemented cookie adapter (near/actix-extras@f3e6f09) that was removed from `actix-http` (actix/actix-web#2065) - Forked [`paperclip`](https://github.com/near/paperclip) and updated `actix-web`, adding and defaulting to the `actix4` feature flag (near/paperclip@b9589c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Improvement
PR Checklist
Overview
Removes cookie features from -http. Part of this effort necessarily included creating a response and response builder structs in -web; as far as I can see, the changes in this PR are as small as possible to achieve it.