add interval check for payload pending #2032
Conversation
fakeshadow
added
A-http
|
Draft this for now until finding a way to detect client disconnect |
|
Should this active across aboard or put behind a feature gate? |
|
What's the rationale for wanting a feature flag? You expect a perf hit? |
|
I suspect this could conflict with user keep alive code like a longer heartbeat they define with extra logic on heartbeat expire. This could end the connection before their heartbeat logic kick in hense breaking. I'm not sure about this though just a guess. |
|
Is there anything I can help with to move this forward? We believe that this issue is the root cause behind an issue we have been running into running actix behind envoy. |
Thanks for asking. I want to make a bit clearify that this PR is not an issue fix but mostly a feature(a hacky one). The problem of this feature is it goes against convensional handing of Rust future/stream type and may cause problem for people expecting otherwise. Like this #2032 (comment) discussed. It would be pretty hard to test the possibility of break people code so I tend to give this PR sometime and potentially make it a gated feature that is opt-in. Edit: It would be appreciated to help test and/or help putting this behind a feature. I would try to keep this PR in sync with master |
|
I don't have time to keep up the sync with master branch anymore. |
PR Type
Feature
PR Checklist
Overview
Add interval check(1 second) on Io stream's read status when response payload stream enters pending.
When interval check detect Io is not readable anymore it would assume remote client have disconnect and end dispatcher. All unfinished responses would be lost.
Closes #1313