rework client connection pool #1994
Merged
+521
−481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakeshadow
added
A-awc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Overview
Rework actix-http client connection pool. This pool is only used in awc and is fairly complicated.
This PR use a more heavy but simpler approach. A
tokio::sync::Semaphoreis used to limit concurrent access to pool and connection's lifecycle is only checked when they are popped from pool.In theory this would make the pool slower and more memory hungry but it's arguable noticeable in real world.
And follow up changes can made into the new pool to adjust these problems if they show.