Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pin-project to 1.0 #1733

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Bump pin-project to 1.0 #1733

merged 1 commit into from
Oct 25, 2020

Conversation

ghizzo01
Copy link
Contributor

PR Type

INSERT_PR_TYPE

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Sorry, something went wrong.

@robjtede robjtede added A-awc project: awc A-http project: actix-http A-test-server project: test-server A-web project: actix-web B-semver-patch A-actors project: actix-web-actors labels Oct 14, 2020
@JohnTitor
Copy link
Member

If you split this into two PRs, one is for pin-project and another is for base64, I'm happy to merge the latter for now.

@ghizzo01 ghizzo01 mentioned this pull request Oct 19, 2020
@ghizzo01 ghizzo01 changed the title Bump pin-project to 1.0 and base64 to 0.13 Bump pin-project to 1.0 Oct 25, 2020
@ghizzo01
Copy link
Contributor Author

futures 0.3.7 is out, bumping pin-project to 1.0

@codecov-io
Copy link

Codecov Report

Merging #1733 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1733   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files         127      129    +2     
  Lines       12062    12060    -2     
=======================================
  Hits         6487     6487           
+ Misses       5575     5573    -2     
Impacted Files Coverage Δ
actix-http/src/header/common/accept.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/if_match.rs
actix-http/src/header/common/content_language.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/allow.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/expires.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/mod.rs 11.11% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e5042...d7c413f. Read the comment docs.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit 20078fe into actix:master Oct 25, 2020

Verified

This commit was signed with the committer’s verified signature.
ali-ramadhan Ali Ramadhan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-actors project: actix-web-actors A-awc project: awc A-http project: actix-http A-test-server project: test-server A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants