Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web::ReqData extractor #1729

Closed
wants to merge 2 commits into from
Closed

Add web::ReqData extractor #1729

wants to merge 2 commits into from

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Oct 9, 2020

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Adds a ReqData extractor for request data / request extensions, analogous to web::Data.

@robjtede robjtede added A-web project: actix-web B-semver-minor labels Oct 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #1729 into master will decrease coverage by 0.01%.
The diff coverage is 32.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
- Coverage   53.48%   53.46%   -0.02%     
==========================================
  Files         128      126       -2     
  Lines       11981    11998      +17     
==========================================
+ Hits         6408     6415       +7     
- Misses       5573     5583      +10     
Impacted Files Coverage Δ
src/config.rs 93.10% <ø> (ø)
src/data.rs 94.39% <ø> (ø)
src/lib.rs 68.42% <ø> (ø)
src/request_data.rs 0.00% <0.00%> (ø)
src/web.rs 85.71% <ø> (ø)
src/scope.rs 93.43% <40.00%> (-0.66%) ⬇️
src/app_service.rs 86.80% <50.00%> (-1.31%) ⬇️
src/app.rs 98.98% <100.00%> (ø)
actix-http/src/h1/encoder.rs 62.90% <0.00%> (-0.41%) ⬇️
actix-http/src/h1/decoder.rs 62.88% <0.00%> (-0.35%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b23f3...1424a46. Read the comment docs.

@robjtede
Copy link
Member

Hey @jplatte. Would be cool to see this in to v3.2. If you don't have the bandwidth just say so I can polish it up.

@jplatte
Copy link
Contributor Author

jplatte commented Oct 19, 2020

Yeah not sure when I'll get back to this. Would be great if you could finish it!

@robjtede robjtede linked an issue Oct 19, 2020 that may be closed by this pull request
@robjtede robjtede mentioned this pull request Oct 20, 2020
4 tasks
@robjtede
Copy link
Member

robjtede commented Oct 20, 2020

I didn't seem to be able to push to this branch so created a new PR (#1748) that includes the original commits. Closing this one.

@robjtede robjtede closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request data extractor similar to web::Data
3 participants