Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sized Bound for web::Data #1712

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Conversation

PeterUlb
Copy link
Contributor

@PeterUlb PeterUlb commented Sep 26, 2020

PR Type

Improvement

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made in CHANGES.md
  • Format code with the latest stable rustfmt

Overview

See #1710. It's now possible to use Arc as a source for constructing web::Data. Arc itself already supports it, so the Data wrapper should too. Otherwise there's yet another wrapper required.

Closes #1710

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #1712 into master will increase coverage by 0.05%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
+ Coverage   53.47%   53.53%   +0.05%     
==========================================
  Files         125      128       +3     
  Lines       11969    11970       +1     
==========================================
+ Hits         6401     6408       +7     
+ Misses       5568     5562       -6     
Impacted Files Coverage Δ
src/data.rs 94.39% <87.50%> (-0.56%) ⬇️
actix-http/src/header/common/accept.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/allow.rs
actix-http/src/header/common/if_modified_since.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/etag.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/if_none_match.rs 0.00% <0.00%> (ø)
...ctix-http/src/header/common/if_unmodified_since.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/mod.rs 10.00% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e02fe...5acc78e. Read the comment docs.

Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense given this is a glorified Arc 👍

@robjtede robjtede merged commit b5812b1 into actix:master Sep 29, 2020
@robjtede robjtede added A-web project: actix-web B-semver-minor labels Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid Double Arc for Arc<dyn> with T: ?Sized
3 participants