Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trimming to inaccessible root path #1678

Merged
merged 3 commits into from Sep 15, 2020
Merged

Conversation

robjtede
Copy link
Member

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

When using TrailingSlash::Trim, the root path was getting trimmed to a blank string, making it inaccessible.

@robjtede robjtede requested a review from a team September 13, 2020 15:08
@robjtede robjtede added the A-web project: actix-web label Sep 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #1678 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
+ Coverage   53.42%   53.51%   +0.08%     
==========================================
  Files         123      123              
  Lines       11855    11876      +21     
==========================================
+ Hits         6334     6355      +21     
  Misses       5521     5521              
Impacted Files Coverage Δ
src/middleware/normalize.rs 98.33% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4c9d1...0035003. Read the comment docs.

@robjtede robjtede requested a review from a team September 13, 2020 23:57
@robjtede
Copy link
Member Author

Anyone from @actix/contributors free to review this small fix? Could do with this getting released to make TrailingSlash::Trim usable.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@robjtede robjtede merged commit 7f80732 into master Sep 15, 2020
@robjtede robjtede deleted the fix/normalize-trim-root branch September 15, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants