ameliorate awc timeouts on windows

[robjtede]

PR Type

Bug Workaround

PR Checklist

• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

Works around issues on Windows seemingly caused by slow DNS lookups by doubling the default timeout period when built for Windows.

See conversation in #1560

cc: @Pzixel @popzxc

[popzxc]

I guess, it is now possible to make awc doctests use https. However, I'm not sure if it's right thing to do, as the Windows tests will still be very slow and may randomly fail.

[codecov-commenter]

Codecov Report

Merging #1662 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   53.34%   53.32%   -0.02%     
==========================================
  Files         120      120              
  Lines       11815    11819       +4     
==========================================
  Hits         6303     6303              
- Misses       5512     5516       +4     

Impacted Files	Coverage Δ
awc/src/builder.rs	19.67% <0.00%> (-0.33%)	⬇️
actix-http/src/header/common/mod.rs	14.28% <0.00%> (-2.39%)	⬇️
actix-http/src/header/common/content_language.rs
actix-http/src/header/common/last_modified.rs
actix-http/src/header/common/if_match.rs	0.00% <0.00%> (ø)
actix-http/src/header/common/if_modified_since.rs	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39d166...3923159. Read the comment docs.

[robjtede]

However, I'm not sure if it's right thing to do...

I'm not totally sure either, but the other thing to do for now is nothing... :/

[Pzixel]

I still believe 10 sec delay for any request is insane. It doesn't actually fix the problem as I see it, it only changes its kind

[popzxc]

But as we already pointed before, the problem is not located within any of the actix crates.

Proper ways of resolving this issue (which are either replacing the dependency or fixing the issue in the dependency, and then waiting for it to release a new version) will take much longer.

IMHO, slowly working code is better that code that doesn't work. So I think that it's an acceptable temporary workaround.

By the way, any help with a proper solution will be really appreciated 🙃

[Pzixel]

I aggree. But I don't think 10 sec NS lookup is anywhere near acceptable.

So I'd propose to either not deliver the crate on windows at all (with CFG and explanation) or no actions to "fix" it in this crate. It's indeed dependencies problem, so the proper solution is fixing/replacing dependency. I probably should create an issue in this dependency repository if you didn't already.

Any fix is appreciated if it helps, but this one just changes one problem (not working at all) to another (working inapplicable slowly).

But I'm not strong on this point so you may right with this fix

[cetra3]

Looks like we're working around a bug in trust-dns so I'm not in support of this change. I have had issues with that crate before, so I think a more appropriate fix is to raise it in there.