Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update msrv to 1.56 #2777

Merged
merged 2 commits into from Jun 11, 2022
Merged

update msrv to 1.56 #2777

merged 2 commits into from Jun 11, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Jun 6, 2022 •
edited

PR Type

MSRV

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • (Team) Label with affected crates and semver status.

Overview

Bump MSRV to 1.56, following hashbrown.

Generally, it's fine to do this in a minor release.

@robjtede robjtede force-pushed the 156 branch 2 times, most recently from 8db7ae8 to cf0147b Compare June 6, 2022 18:04
@robjtede robjtede requested a review from JohnTitor June 6, 2022 18:06
@JohnTitor
Copy link
Member

CI failed:

error: package `dashmap v5.3.4` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0

We have to bump up to 1.59, it seems. It also may be better to describe that this is due to our dependency on changelog, not to confuse users.

@robjtede robjtede linked an issue Jun 7, 2022 that may be closed by this pull request
consider making firestorm dependency of actix-router optional #2747
Closed
JohnTitor
JohnTitor approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with updating changelog (I mean something like "... is now 1.56. This is because one of our dependencies updated MSRV without a major release.". Some of users should be aware of it already but just in case someone wonders why actix breaks MSRV in a minor version.)

@robjtede robjtede enabled auto-merge (squash) June 11, 2022 02:55
@robjtede robjtede disabled auto-merge June 11, 2022 03:03
@robjtede robjtede merged commit 2253eae into master Jun 11, 2022
@robjtede robjtede deleted the 156 branch June 11, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider making firestorm dependency of actix-router optional
2 participants
@robjtede @JohnTitor