Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider making firestorm dependency of actix-router optional #2747

Closed
matklad opened this issue Apr 26, 2022 · 0 comments · Fixed by #2777
Closed

consider making firestorm dependency of actix-router optional #2747

matklad opened this issue Apr 26, 2022 · 0 comments · Fixed by #2777

Comments

@matklad
Copy link

matklad commented Apr 26, 2022

I've noticed firestorm dependency in Cargo.lock of my application. This dependency comes from actix-router. My understanding is that this is a dev-tool used for internal profiling of actix-router.

I understand that it is a no-op crate by default, but I still would prefer not to have this entry in my Cargo.lock to avoid worrying about supply chain attacks and spending time on figuring out why this relatively unknown crate is there.

robjtede added a commit that referenced this issue Jun 7, 2022
@robjtede robjtede linked a pull request Jun 7, 2022 that will close this issue
4 tasks
robjtede added a commit that referenced this issue Jun 11, 2022
robjtede added a commit that referenced this issue Jun 11, 2022
* update msrv to 1.56

* remove transitive dashmap dependency

closes #2747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant