Skip to content

Commit

Permalink
temp demonstrate failure
Browse files Browse the repository at this point in the history
  • Loading branch information
robjtede committed Oct 30, 2023
1 parent 2a9edd6 commit 0013ab5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Expand Up @@ -81,7 +81,7 @@ jobs:
tool: cargo-check-external-types@0.1.10

- name: check external types
run: just check-external-types-all
run: just check-external-types-all +nightly-2023-10-10

public-api-diff:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion awc/Cargo.toml
Expand Up @@ -21,7 +21,7 @@ features = ["openssl", "rustls-0_20", "rustls-0_21", "compress-brotli", "compres

[package.metadata.cargo_check_external_types]
allowed_external_types = [
"actix_codec::*",
# "actix_codec::*",
"actix_http::*",
"actix_rt::*",
"actix_service::*",
Expand Down
12 changes: 6 additions & 6 deletions justfile
Expand Up @@ -11,27 +11,27 @@ doc-watch:
cargo watch -- RUSTDOCFLAGS="--cfg=docsrs" cargo +nightly doc --no-deps --workspace --features=rustls,openssl

# Check for unintentional external type exposure on all crates in workspace.
check-external-types-all:
check-external-types-all toolchain="+nightly":
#!/usr/bin/env bash
set -euo pipefail
exit=0
for f in $(find . -mindepth 2 -maxdepth 2 -name Cargo.toml | grep -vE "\-codegen/|\-derive/|\-macros/"); do
if ! just check-external-types-manifest "$f"; then exit=1; fi
if ! just check-external-types-manifest "$f" {{toolchain}}; then exit=1; fi
echo
echo
done
exit $exit

# Check for unintentional external type exposure on all crates in workspace.
check-external-types-all-table:
check-external-types-all-table toolchain="+nightly":
#!/usr/bin/env bash
set -euo pipefail
for f in $(find . -mindepth 2 -maxdepth 2 -name Cargo.toml | grep -vE "\-codegen/|\-derive/|\-macros/"); do
echo
echo "Checking for $f"
just check-external-types-manifest "$f" --output-format=markdown-table
just check-external-types-manifest "$f" {{toolchain}} --output-format=markdown-table
done

# Check for unintentional external type exposure on a crate.
check-external-types-manifest manifest_path *extra_args:
cargo +nightly check-external-types --manifest-path "{{manifest_path}}" {{extra_args}}
check-external-types-manifest manifest_path toolchain="+nightly" *extra_args="":
cargo {{toolchain}} check-external-types --manifest-path "{{manifest_path}}" {{extra_args}}

0 comments on commit 0013ab5

Please sign in to comment.