Skip to content

Strip non-address characters from Forwarded for= #236

Strip non-address characters from Forwarded for=

Strip non-address characters from Forwarded for= #236

Triggered via pull request April 26, 2024 07:32
Status Failure
Total duration 1m 22s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 1 warning
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
public-api-diff
use of unstable library feature 'saturating_int_impl'
clippy: actix-web/src/info.rs#L26
[clippy] reported by reviewdog 🐶 error: single-character string constant used as pattern --> actix-web/src/info.rs:26:24 | 26 | if val.starts_with("[") { | ^^^ help: consider using a `char`: `'['` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `-D clippy::single-char-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]` Raw Output: actix-web/src/info.rs:26:24:e:error: single-character string constant used as pattern --> actix-web/src/info.rs:26:24 | 26 | if val.starts_with("[") { | ^^^ help: consider using a `char`: `'['` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `-D clippy::single-char-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]` __END__
clippy: actix-web/src/info.rs#L27
[clippy] reported by reviewdog 🐶 error: unnecessary use of `splitn` --> actix-web/src/info.rs:27:9 | 27 | val.splitn(2, "]:") | ^^^^^^^^^^^^^^^^^^^ help: try: `val.split("]:")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn = note: `-D clippy::needless-splitn` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_splitn)]` Raw Output: actix-web/src/info.rs:27:9:e:error: unnecessary use of `splitn` --> actix-web/src/info.rs:27:9 | 27 | val.splitn(2, "]:") | ^^^^^^^^^^^^^^^^^^^ help: try: `val.split("]:")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn = note: `-D clippy::needless-splitn` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_splitn)]` __END__
clippy: actix-web/src/info.rs#L33
[clippy] reported by reviewdog 🐶 error: unnecessary use of `splitn` --> actix-web/src/info.rs:33:9 | 33 | val.splitn(2, ":").next().unwrap_or(val) | ^^^^^^^^^^^^^^^^^^ help: try: `val.split(":")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn Raw Output: actix-web/src/info.rs:33:9:e:error: unnecessary use of `splitn` --> actix-web/src/info.rs:33:9 | 33 | val.splitn(2, ":").next().unwrap_or(val) | ^^^^^^^^^^^^^^^^^^ help: try: `val.split(":")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn __END__
clippy: actix-web/src/info.rs#L33
[clippy] reported by reviewdog 🐶 error: single-character string constant used as pattern --> actix-web/src/info.rs:33:23 | 33 | val.splitn(2, ":").next().unwrap_or(val) | ^^^ help: consider using a `char`: `':'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern Raw Output: actix-web/src/info.rs:33:23:e:error: single-character string constant used as pattern --> actix-web/src/info.rs:33:23 | 33 | val.splitn(2, ":").next().unwrap_or(val) | ^^^ help: consider using a `char`: `':'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern __END__
clippy
reviewdog exited with status code: 1
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: giraffate/clippy-action@v1.0.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.